Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils: Test for triangle normal calculation. #3391

Merged
merged 2 commits into from
Jan 2, 2020
Merged

utils: Test for triangle normal calculation. #3391

merged 2 commits into from
Jan 2, 2020

Conversation

fweik
Copy link
Contributor

@fweik fweik commented Dec 27, 2019

Description of changes:

  • Document the sign convention for the triangle functions
  • Test normal calculation.

@fweik fweik requested a review from jngrad December 27, 2019 16:43
jngrad
jngrad approved these changes Dec 27, 2019
View reviewed changes
Copy link
Member

@jngrad jngrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 27, 2019 •
edited
Loading

Codecov Report

Merging #3391 into python will increase coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #3391    +/-   ##
=======================================
+ Coverage      86%     86%   +<1%     
=======================================
  Files         537     538     +1     
  Lines       25287   25307    +20     
=======================================
+ Hits        21809   21827    +18     
- Misses       3478    3480     +2
Impacted Files Coverage Δ
...rc/utils/include/utils/math/triangle_functions.hpp 91% <ø> (ø) ⬆️
src/utils/tests/triangle_functions_test.cpp 100% <100%> (ø)
src/core/particle_data.cpp 96% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd7e1d5...0735a83. Read the comment docs.

@jngrad jngrad added the automerge Merge with kodiak label Jan 2, 2020
@kodiakhq kodiakhq bot merged commit 0fa0e60 into espressomd:python Jan 2, 2020
@jngrad jngrad added this to the Espresso 4.1.3 milestone Feb 28, 2020
@fweik fweik deleted the triangle_fct branch August 27, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jngrad jngrad jngrad approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak Core Testcase
Projects
None yet
Milestone
Espresso 4.1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@fweik @jngrad